On Sat, 22 Oct 2011 15:27:04 +0200, Michael Karcher <[email protected]> wrote: > Am Samstag, den 22.10.2011, 14:19 +0200 schrieb Diego Biurrun: > > > I wonder if you could not (easily) put the muxer in a separate file and > > skip the ifdeffery. > This is indeed possible, except for the sample rate table mentioned > above, which is shared between encoder and decoder. I expect making > three files out of it (one shared, containing only the sample rate > table, one for the muxer, one for the demuxer) is overkill, the other > two options are duplicating the table or using the ifdefs as it is now. > I don't think there is an option to have the compiler merge the tables > if they are identically defined in two source files (which gcc does for > strings)
I'd say with such a small table it doesn't really matter if you duplicate it in the binary by putting it in a header file (but feel free to make a separate file for shared data if you prefer). In any case, I would also prefer if the muxer and demuxer were in different files. Otherwise the patch looks fine, except for some minor cosmetics like brace placement inconsistent with the rest of libav. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
