On Wed, Oct 26, 2011 at 3:15 AM, Diego Biurrun <[email protected]> wrote:

> On Wed, Oct 26, 2011 at 02:09:29AM -0400, Daniel Kang wrote:
> > Also remove some useless 3dnow ASM.
>
> What about the 3DNow! asm?


The parts with 3dnow that have YASM mmx equivalents have been dropped. AMD
has dropped support for 3dnow [1] and the OK was given by Jason and Ronald.

> --- a/libavcodec/x86/dsputil_mmx.c
> > +++ b/libavcodec/x86/dsputil_mmx.c
> > @@ -2747,37 +2664,33 @@ void dsputil_init_mmx(DSPContext* c,
> AVCodecContext *avctx)
> >
> > +#define H264_QPEL_FUNCS8(x, y, CPU)\
> > +            c->put_h264_qpel_pixels_tab[1][x+y*4] =
> ff_put_h264_qpel8_mc##x##y##_##CPU;
> >          if(mm_flags & AV_CPU_FLAG_SSE2){
> >              if (!high_bit_depth) {
> > -            H264_QPEL_FUNCS(0, 1, sse2);
> > -            H264_QPEL_FUNCS(0, 2, sse2);
> > -            H264_QPEL_FUNCS(0, 3, sse2);
> > -            H264_QPEL_FUNCS(1, 1, sse2);
> > -            H264_QPEL_FUNCS(1, 2, sse2);
> > -            H264_QPEL_FUNCS(1, 3, sse2);
> > -            H264_QPEL_FUNCS(2, 1, sse2);
> > -            H264_QPEL_FUNCS(2, 2, sse2);
> > -            H264_QPEL_FUNCS(2, 3, sse2);
> > -            H264_QPEL_FUNCS(3, 1, sse2);
> > -            H264_QPEL_FUNCS(3, 2, sse2);
> > -            H264_QPEL_FUNCS(3, 3, sse2);
> > +                H264_QPEL_FUNCS(0, 0, sse2);
> > +                H264_QPEL_FUNCS(0, 1, sse2);
> > +                H264_QPEL_FUNCS(0, 2, sse2);
> > +                H264_QPEL_FUNCS(0, 3, sse2);
> > +                H264_QPEL_FUNCS(1, 0, sse2);
> > +                H264_QPEL_FUNCS(1, 1, sse2);
> > +                H264_QPEL_FUNCS(1, 2, sse2);
> > +                H264_QPEL_FUNCS(1, 3, sse2);
> > +                H264_QPEL_FUNCS(2, 0, sse2);
> > +                H264_QPEL_FUNCS(2, 1, sse2);
> > +                H264_QPEL_FUNCS(2, 2, sse2);
> > +                H264_QPEL_FUNCS(2, 3, sse2);
> > +                H264_QPEL_FUNCS(3, 0, sse2);
> > +                H264_QPEL_FUNCS(3, 1, sse2);
> > +                H264_QPEL_FUNCS(3, 2, sse2);
> > +                H264_QPEL_FUNCS(3, 3, sse2);
>
> Please split this off into a separate patch.
>

Done.

[1] http://blogs.amd.com/developer/2010/08/18/3dnow-deprecated/
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to