On Thu, Oct 27, 2011 at 09:32:20AM -0400, Justin Ruggles wrote:
> On 10/27/2011 01:37 AM, Kostya Shishkov wrote:
>
> > On Wed, Oct 26, 2011 at 04:18:20PM -0400, Justin Ruggles wrote:
> >> ---
> >> libavcodec/apedec.c | 8 ++++----
> >> 1 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
> >> index 031dee4..847b4ad 100644
> >> --- a/libavcodec/apedec.c
> >> +++ b/libavcodec/apedec.c
> >> @@ -182,15 +182,15 @@ static av_cold int ape_decode_init(AVCodecContext *
> >> avctx)
> >>
> >> if (avctx->extradata_size != 6) {
> >> av_log(avctx, AV_LOG_ERROR, "Incorrect extradata\n");
> >> - return -1;
> >> + return AVERROR(EINVAL);
> >> }
> >> if (avctx->bits_per_coded_sample != 16) {
> >> av_log(avctx, AV_LOG_ERROR, "Only 16-bit samples are
> >> supported\n");
> >> - return -1;
> >> + return AVERROR(EINVAL);
> >> }
> >> if (avctx->channels > 2) {
> >> av_log(avctx, AV_LOG_ERROR, "Only mono and stereo is
> >> supported\n");
> >> - return -1;
> >> + return AVERROR(EINVAL);
> >
> > PATCHWELCOME might be better, I heard that there are 24-bit APE samples, for
> > example.
>
>
> Ok, and I'll also change those av_log to av_log_ask_for_sample().
Yes, that would be good.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
