On Mon, 31 Oct 2011 06:55:21 -0700, "Ronald S. Bultje" <[email protected]> 
wrote:
> Hi,
> 
> On Mon, Oct 31, 2011 at 6:28 AM, Martin Storsjö <[email protected]> wrote:
> > This symbol name clashes with a symbol in gnutls, if linking
> > statically to that library.
> > ---
> >  avconv.c   |    2 +-
> >  cmdutils.c |    2 +-
> >  cmdutils.h |    2 +-
> >  ffmpeg.c   |    2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> You can commit this separately from the rest of the patch, it's obviously OK.
> 

While it shouldn't cause any trouble, I'd prefer you use something other
than ff_ here. ff_ is used for internal libav* functions, so using it
for a cmdutils function is confusing.

cmdutils_read_file() would be better IMO (or something shorter if you prefer)


-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to