On Mon, Oct 31, 2011 at 08:11:09AM +0100, Diego Biurrun wrote:
> On Sun, Oct 30, 2011 at 06:07:49PM -0400, Justin Ruggles wrote:
> > On 10/30/2011 05:10 PM, Diego Biurrun wrote:
> >
> > > --- a/libavcodec/mpeg4videodec.c
> > > +++ b/libavcodec/mpeg4videodec.c
> > > @@ -1854,7 +1854,7 @@ static int decode_user_data(MpegEncContext *s,
> > > GetBitContext *gb){
> > >
> > > - /* ffmpeg detection */
> > > + /* libavcodec detection */
> > > e=sscanf(buf, "FFmpe%*[^b]b%d", &build)+3;
> > > if(e!=4)
> > > e=sscanf(buf, "FFmpeg v%d.%d.%d / libavcodec build: %d", &ver,
> > > &ver2, &ver3, &build);
> >
> > i don't understand this change. it looks like it detects ffmpeg to me.
>
> Writing libavcodec there seemed slightly more accurate to me since lavc
> is the actual encoder backend whose quirks are being worked around and
> both lavc used with other frontends as well as ffmpeg used with other
> backends are possible combinations.
Indeed, LGTM
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
