On Wed, Nov 02, 2011 at 11:48:51PM +0100, Diego Biurrun wrote:
> From: Sebastien Zwickert <[email protected]>
> 
> Signed-off-by: Luca Barbato <[email protected]>
> Signed-off-by: Diego Biurrun <[email protected]>
> ---
> diff --git a/configure b/configure
> index c23660e..a747f2a 100755
> --- a/configure
> +++ b/configure
> @@ -1290,6 +1292,7 @@ h264_decoder_select="golomb h264dsp h264pred"
>  h264_dxva2_hwaccel_deps="dxva2api_h"
>  h264_dxva2_hwaccel_select="dxva2 h264_decoder"
>  h264_vaapi_hwaccel_select="vaapi"
> +h264_vda_hwaccel_select="vda"
>  h264_vdpau_decoder_select="vdpau h264_decoder"
>  imc_decoder_select="fft mdct sinewin"
>  jpegls_decoder_select="golomb"

it looks like it needs the h264_decoder, unrelated: vaapi probably too

> @@ -1386,6 +1389,7 @@ zmbv_decoder_select="zlib"
>  zmbv_encoder_select="zlib"
>
>  vaapi_deps="va_va_h"
> +vda_deps="VideoDecodeAcceleration_VDADecoder_h"
>  vdpau_deps="vdpau_vdpau_h vdpau_vdpau_x11_h"

vda depends on pthreads, it probably should select it, since pthreads
should be always available.


> --- a/doc/general.texi
> +++ b/doc/general.texi
> @@ -414,6 +414,7 @@ following image formats are supported:
>  @item H.263+ / H.263-1998 / H.263 version 2  @tab  X  @tab  X
>  @item H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10  @tab  E  @tab  X
>      @tab encoding supported through external library libx264
> +@item H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10 (VDA acceleration)  @tab     
> @tab  X
>  @item H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10 (VDPAU acceleration)  @tab  
> E  @tab  X

I suspect the HW-accels are listed somewhere else. VDPAU is not yet
converted to a HW-accel

> diff --git a/libavcodec/vda.h b/libavcodec/vda.h
> new file mode 100644
> index 0000000..b3362de
> --- /dev/null
> +++ b/libavcodec/vda.h
> @@ -0,0 +1,138 @@
> +/*
> + * VDA HW acceleration
> + *
> + * copyright (c) 2011 Sebastien Zwickert
> + *
> + * This file is part of Libav.
> + *
> + * Libav is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * Libav is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with Libav; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
> USA
> + */
> +
> +#ifndef AVCODEC_VDA_H
> +#define AVCODEC_VDA_H
> +
> +#include <stdint.h>
> +
> +// emmintrin.h is unable to compile with -std=c99 -Werror=missing-prototypes
> +// http://openradar.appspot.com/8026390
> +#undef __GNUC_STDC_INLINE__

which file includes emmintrin.h? this #undef in a installed header is
very ugly.

> +
> +#define Picture QuickdrawPicture
> +
> +#include <pthread.h>

pthread.h is not used in this file

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to