Luca Barbato <[email protected]> writes: > On 11/4/11 9:45 AM, Kostya Shishkov wrote: >> On Fri, Nov 04, 2011 at 04:42:11PM +0000, Måns Rullgård wrote: >>> Luca Barbato<[email protected]> writes: >>> >>>> On 11/4/11 9:28 AM, Måns Rullgård wrote: >>>>> Write it in a non-ugly way of course. >>>> >>>> Let me expand: >>>> >>>> - the strcasecmp/strncasecmp itself isn't much different than the >>>> usual libc implementation, the toupper can enjoy a better >>>> implementation (to be noted that in all libc I had a look into strcase >>>> uses tolower). >>> >>> Yes, that macro is what I was talking about. >> >> What about >> >> #define TOUPPER(c) \ >> if (c>= 'a'&& c<= 'z') \ >> c ^= 0x20; > > Looks nicer.
I'd make it a bit more function-like or even an inline function. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
