On 11/05/2011 06:58 AM, Martin Storsjö wrote: > From: Carl Eugen Hoyos <[email protected]> > > Earlier, sc->samples_per_frame was used for setting the frame size, > but all files don't have that set properly. The frame size is a > known constant for these codecs. > > If frame_size isn't set, the mov/3gp muxer refuses to mux it. > > This fixes stream copy of audio from > https://roundup.libav.org/file1248/Video_With_AMR-NB_Audio.3gp > to another 3gp file (roundup issue 2468).
That frame_size check in the mov/3gp muxer that prevents stream copy in this case is unnecessary. The field is not even used when writing 3gp. Even if we remove all setting of frame_size at all in the demuxer, the timestamps are still able to be calculated correctly, and the muxer will write correct output if the frame_size check is removed. For mov muxing, where frame_size is used in the SoundDescription, the correct packet duration is written in the stts atom even without frame_size set. That said, I don't object to the patch, as it doesn't do any harm. But separate from this, I think the mov muxer needs to be fixed... it should not require frame_size to be set, at least not for all cases. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
