On Mon, 7 Nov 2011, Ronald S. Bultje wrote:

On Mon, Nov 7, 2011 at 6:58 AM, Kostya Shishkov
<[email protected]> wrote:
On Sat, Nov 05, 2011 at 03:14:12PM +0100, Kostya Shishkov wrote:
On Sat, Nov 05, 2011 at 10:00:51AM -0400, Justin Ruggles wrote:
From 6ee16a50e822823bc329c0eb2035ae42439271aa Mon Sep 17 00:00:00 2001
From: Kostya Shishkov <[email protected]>
Date: Tue, 1 Nov 2011 11:58:44 +0100
Subject: [PATCH] BMV demuxer and decoder

[...]
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index c3cd023..9a6dd31 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -215,6 +215,7 @@ enum CodecID {
     CODEC_ID_G729,
 #endif
     CODEC_ID_UTVIDEO,
+    CODEC_ID_BMV,

     /* various PCM "codecs" */
     CODEC_ID_FIRST_AUDIO = 0x10000,     ///< A dummy id pointing at the start 
of audio codecs
@@ -351,6 +352,7 @@ enum CodecID {
     CODEC_ID_G723_1,
     CODEC_ID_G729,
 #endif
+    CODEC_ID_BMV_AUD,


why not CODEC_ID_BMV_VIDEO and CODEC_ID_BMV_AUDIO? it's not that much
longer.

Why not indeed? Renamed.

+/*
+ * Discworld II BMV video decoder


Discworld II BMV video and audio decoder

the audio part looks good.

[...]

+            pkt->pts          = c->audio_pos;
+            c->audio_pos += c->packet[1] * 32;


how about:
pkt->pts      = c->audio_pos;
pkt->duration = c->packet[1] * 32;
c->audio_pos += pkt->duration;

Again, why not. Done so.

Here's a patch updated to the latest Git. There were some changes in versions
and changelog since.

Should be OK.

Applied.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to