On Tue, 15 Nov 2011, Janne Grunau wrote:

On Tue, Nov 08, 2011 at 02:28:27PM +0000, Måns Rullgård wrote:
Janne Grunau <[email protected]> writes:

> @@ -2867,6 +2866,10 @@ if ! disabled pthreads && ! enabled w32threads; then
>      fi
>  fi
>
> +if ! enabled pthreads; then
> +    test $target_os = "mingw32" &&  enable_weak w32threads
> +fi

That is just introducing another OS "section" which is not at all what I
had in mind.  I'd like to do it in an OS-independent way if at all
possible as it would then work automatically for anything else
supporting windows threads (if such a thing exists).

point taken, patch updated

I'm also not sure either of these patches provide the most intuitive
semantics.  To disable threads entirely on a win32 system, both
--disable-pthreads and --disable-w32threds must be used.

only if we detect pthreads support but I don't really see an elegant way around it other than adding a --disable-threading option.

Martin, please verify that the test fails for mingw32ce

Seems to work as intended, w32threads isn't enabled on mingw32ce, and is enabled on mingw32.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to