Justin Ruggles <[email protected]> writes:

> A new field, AVCodecContext.internal_context is used to hold a new struct
> AVCodecInternal, which has private fields that are not codec-specific and are
> needed only by general libavcodec functions.
>
> Moved user_buffer, user_buffer_count, and is_copy.
> ---
>  doc/APIchanges         |    8 +++++
>  libavcodec/avcodec.h   |   22 +++++++++++--
>  libavcodec/h264.c      |    4 ++-
>  libavcodec/internal.h  |   22 +++++++++++++
>  libavcodec/mimic.c     |    5 ++-
>  libavcodec/mpegvideo.c |    3 +-
>  libavcodec/options.c   |    4 ++-
>  libavcodec/pthread.c   |    7 ++--
>  libavcodec/utils.c     |   78 
> +++++++++++++++++++++++++++---------------------
>  libavcodec/version.h   |    5 ++-
>  libavcodec/vp3.c       |    5 ++-
>  libavcodec/vp8.c       |    4 ++-
>  12 files changed, 120 insertions(+), 47 deletions(-)

[...]

> +    /**
> +     * Private context used for internal data.
> +     *
> +     * Unlike priv_data, this is not codec-specific. It is used in general
> +     * libavcodec functions.
> +     */
> +    void *internal_context;

Please make this an opaque struct type instead of void*.  It will
simplify some code and provide type checking.

I'd probably have named it simply "internal" too, saves a bit of typing.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to