Hi, On Sat, Nov 26, 2011 at 3:59 AM, Victor Vasiliev <[email protected]> wrote: > The first patch moves RIFF INFO tag writing from avienc.c to riff.c, > and introduces INFO tags writing into wav.c. > > I had a choice between writing empty INFO section when tags were > absent or omitting it as a whole. The first would mean I would have to > alter all WAV files in tests, the second would mean I have to alter > all AVI files in tests. I chose the second because it felt more > correct and robust; the second patch (split for better readability) > replaces all AVI reference tests with versions which do not have empty > INFO section, and hence are 12 bytes shorter.
LGTM from me. I'll apply tomorrow if there's no further comments. I'll probably merge the two patches because 1 will cause all tests to fail, which 2 fixes. Even better is if you could split out that part of the patch into its own, so we can commit the "don't write empty info tags in avi files" + all fate updates first, and then the wav part. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
