On 27/11/11 23:30, Ronald S. Bultje wrote:
Hi,

On Sun, Nov 27, 2011 at 2:24 PM, Luca Barbato<[email protected]>  wrote:
On 27/11/11 22:53, Ronald S. Bultje wrote:
On Sun, Nov 27, 2011 at 1:42 PM, Luca Barbato<[email protected]>    wrote:

Simplify a little error resilience calls
---
  libavcodec/error_resilience.c |   26 +++++++++++++-------------
  libavcodec/h263dec.c          |   14 +++++++-------
  libavcodec/h264.c             |   16 ++++++++--------
  libavcodec/intrax8.c          |    2 +-
  libavcodec/mpegvideo.h        |    4 ++++
  libavcodec/rv10.c             |    2 +-
  libavcodec/rv34.c             |    4 ++--
  libavcodec/vc1dec.c           |   18 +++++++++---------
  8 files changed, 45 insertions(+), 41 deletions(-)

I don't quite like the names "ER_END", how about ER_BLK_END or
ER_BLOCK_END or ER_MB/MACROBLOCK_END or so? Same for error.

MB_END and MB_ERROR Could be good?

I like ER_ prefixes. Non-prefixed stuff for things shared all over
libavcodec/ is a recipe for disaster if you ask me. ER_MB_END/ERROR
sounds good.

Shall I namespace the other macros as well while I'm at it?

lu

--

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to