On Thu, Nov 24, 2011 at 05:37:20PM +0100, Luca Barbato wrote:
> It has the same behaviour of the tcp protocol.
> ---
>  libavformat/Makefile     |    1 +
>  libavformat/allformats.c |    3 +-
>  libavformat/unix.c       |  146 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 149 insertions(+), 1 deletions(-)
>  create mode 100644 libavformat/unix.c

Changelog update missing.

> --- /dev/null
> +++ b/libavformat/unix.c
> @@ -0,0 +1,146 @@
> +
> +#include "libavutil/avstring.h"
> +#include "avformat.h"
> +#include <unistd.h>
> +#include "internal.h"
> +#include "network.h"
> +#include "os_support.h"
> +#if HAVE_POLL_H
> +#include <poll.h>
> +#endif
> +#include <sys/time.h>
> +
> +#include <sys/un.h>

system headers before local headers please.

> +    h->priv_data = s;
> +    h->is_streamed = 1;
> +    s->fd = fd;

This could be aligned.

> +URLProtocol ff_unix_protocol = {
> +    "unix",
> +    unix_open,
> +    unix_read,
> +    unix_write,
> +    NULL, /* seek */
> +    unix_close,
> +    .url_get_file_handle = unix_get_file_handle,
> +};

This should use designated initializers.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to