On Sat, Dec 3, 2011 at 8:18 AM, Ronald S. Bultje <[email protected]> wrote:
> Hi,
>
> On Fri, Dec 2, 2011 at 3:23 PM, Nathan Maxson <[email protected]>
> wrote:
>>
>> attached is the updated patch (thanks Måns for giving feedback on the
>> earlier patch)
>
> [..]
>> @@ -558,7 +554,7 @@ static int xan_decode_frame(AVCodecContext *avctx,
>>          return AVERROR_INVALIDDATA;
>>      }
>>
>> -    if ((ret = avctx->get_buffer(avctx, &s->current_frame))) {
>> +    if (ret = avctx->get_buffer(avctx, &s->current_frame)) {
>>          av_log(s->avctx, AV_LOG_ERROR, "get_buffer() failed\n");
>>          return ret;
>>      }
>
> I don't think you want to remove the brackets here, gcc will emit a warning
> if you do that.
>
> Rest OK.
>
> Ronald
>
> _______________________________________________
> libav-devel mailing list
> [email protected]
> https://lists.libav.org/mailman/listinfo/libav-devel
>

Attachment: 0001-fixed-the-coding-style-in-xan.c-updated-2.patch
Description: Binary data

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to