Re: [libav-devel] [PATCH] drawtext: introduce explicit draw/hide variable

[Luca Barbato]

On 04/12/11 21:48, Justin Ruggles wrote:

On 12/04/2011 03:13 PM, Luca Barbato wrote:

---
  libavfilter/vf_drawtext.c |   11 ++++++++++-
  1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
index b7ba89c..cd4386a 100644
--- a/libavfilter/vf_drawtext.c
+++ b/libavfilter/vf_drawtext.c
@@ -116,6 +116,8 @@ typedef struct {
      char   *x_expr, *y_expr;
      AVExpr *x_pexpr, *y_pexpr;      ///<  parsed expressions for x and y
      double var_values[VAR_VARS_NB];
+    char   *d_expr;
+    AVExpr *d_pexpr;
      int draw;                       ///<  set to zero to prevent drawing
  } DrawTextContext;

@@ -135,6 +137,7 @@ static const AVOption drawtext_options[]= {
  {"shadowx",  "set x",                OFFSET(shadowx),            
AV_OPT_TYPE_INT,    {.dbl=0},     INT_MIN,  INT_MAX  },
  {"shadowy",  "set y",                OFFSET(shadowy),            
AV_OPT_TYPE_INT,    {.dbl=0},     INT_MIN,  INT_MAX  },
  {"tabsize",  "set tab size",         OFFSET(tabsize),            
AV_OPT_TYPE_INT,    {.dbl=4},     0,        INT_MAX  },
+{"draw",     "if false do not draw", OFFSET(d_expr),             AV_OPT_TYPE_STRING, 
{.str="1"},   CHAR_MIN, CHAR_MAX },

this help text does not make it clear at all what the draw option
actually does. suggestion:

"true/false expression. if false, do not draw."

I'd reword later (maybe when this information can be print to the users).

lu

--

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel