On 12/04/2011 05:20 PM, Hendrik Leppkes wrote:

> Hi,
> 
> attached patch updates the pcm-mpeg (pcm_bluray) decoder to use the
> new audio decoding API, it seems to have been overlooked in the
> original commit.
> 
> - Hendrik

Thanks. I thought I had found all of them, but it seems I missed one.

> 
> 0001-pcm-mpeg-implement-new-audio-decoding-api.patch
> 
> 
> From 18d8fa96ad5c7f93696a0255237a56415743c4ed Mon Sep 17 00:00:00 2001
> From: Hendrik Leppkes <[email protected]>
> Date: Sun, 4 Dec 2011 23:15:51 +0100
> Subject: [PATCH] pcm-mpeg: implement new audio decoding api
> 
> ---
>  libavcodec/pcm-mpeg.c |   52 
> +++++++++++++++++++++++++++++++++----------------
>  1 files changed, 35 insertions(+), 17 deletions(-)
> 
> diff --git a/libavcodec/pcm-mpeg.c b/libavcodec/pcm-mpeg.c
> index 5d3dd70..88c985f 100644
> --- a/libavcodec/pcm-mpeg.c
> +++ b/libavcodec/pcm-mpeg.c

> -                memcpy(dst16, src, output_size);
> +                memcpy(dst16, src, s->frame.linesize[0]);


we should be copying buf_size bytes here. linesize[0] is padded.

>  #else
>                  do {
>                      *dst16++ = bytestream_get_be16(&src);
> @@ -291,10 +303,13 @@ static int pcm_bluray_decode_frame(AVCodecContext 
> *avctx,
>          }
>      }
>  
> +    *got_frame_ptr   = 1;
> +    *(AVFrame *)data = s->frame;
> +
>      retval = src - avpkt->data;
>      if (avctx->debug & FF_DEBUG_BITSTREAM)
>          av_dlog(avctx, "pcm_bluray_decode_frame: decoded %d -> %d bytes\n",
> -                retval, *data_size);
> +                retval, s->frame.linesize[0]);


same here, but i suppose it's not a big deal in this case.


rest of the patch looks fine.

Thanks,
Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to