On 12/06/2011 07:43 PM, Alex Converse wrote: > On Tue, Dec 6, 2011 at 3:14 PM, Justin Ruggles <[email protected]> > wrote: >> Use Sound Sample Description Version 2 for all MOV files. >> Updated FATE references accordingly. >> Note that ADPCM is treated as compressed audio in version 2. >> --- >> I tested this pretty extensively in QuickTime for Windows. For >> everything I tested, it works ok after the patch if it worked >> before the patch. >> >> libavformat/movenc.c | 61 >> +++++++++++++------------------------------- >> tests/ref/acodec/pcm_s16be | 4 +- >> tests/ref/acodec/pcm_s24be | 4 +- >> tests/ref/acodec/pcm_s32be | 4 +- >> tests/ref/acodec/pcm_s8 | 4 +- >> tests/ref/lavf/mov | 4 +- >> 6 files changed, 28 insertions(+), 53 deletions(-) >> > > Seems reasonable from an AAC and LPCM perspective. Is anyone around > here an expert on ADPCM in mov? I've always found it a bit hairy, > though treating it as compressed data should be a huge win.
ADPCM was a bit tricky. Treating it as uncompressed works sometimes in V1 and sometimes not. With V2 it only seems to work when treating it as compressed. I tested ADPCM_MS, ADPCM_IMA_WAV, and ADPCM_IMA_QT. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
