On Wed, Dec 07, 2011 at 01:24:13PM +0100, Kostya Shishkov wrote:
> On Wed, Dec 07, 2011 at 01:06:25PM +0100, Diego Biurrun wrote:
> >
> > --- a/libavcodec/vorbisdec.c
> > +++ b/libavcodec/vorbisdec.c
> > @@ -676,7 +676,7 @@ static int
> > vorbis_parse_setup_hdr_residues(vorbis_context *vc)
> > /* Validations to prevent a buffer overflow later. */
> > if (res_setup->begin>res_setup->end ||
> > res_setup->end > vc->avccontext->channels * vc->blocksize[1] /
> > 2 ||
> > - (res_setup->end-res_setup->begin) / res_setup->partition_size
> > > V_MAX_PARTITIONS) {
> > + res_setup->end-res_setup->begin / res_setup->partition_size >
> > V_MAX_PARTITIONS) {
>
> you haven't spotted subtraction operator here
>
> the rest looks fine though (but don't forget to run FATE just in case)
I had run FATE, but it did not trip over this error.
Thanks for spotting and saving me from embarassment...
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
