On Thu, Dec 08, 2011 at 12:04:18AM +0000, Paul B. Mahol wrote: > On 12/7/11, Diego Biurrun <[email protected]> wrote: > > On Wed, Dec 07, 2011 at 11:01:22PM +0000, Paul B. Mahol wrote: > >> On 12/7/11, Diego Biurrun <[email protected]> wrote: > >> > On Tue, Dec 06, 2011 at 03:26:37AM +0000, Paul B. Mahol wrote: > >> >> This patch implements CLJR encoder. > >> > > >> --- a/libavcodec/cljr.c > >> +++ b/libavcodec/cljr.c > >> @@ -157,6 +164,8 @@ AVCodec ff_cljr_encoder = { > >> .priv_data_size = sizeof(CLJRContext), > >> .init = encode_init, > >> .encode = encode_frame, > >> - .long_name = NULL_IF_CONFIG_SMALL("Cirrus Logic AccuPak"), > >> + .pix_fmts = (const enum PixelFormat[]) { PIX_FMT_YUV411P, > >> + PIX_FMT_NONE}, > >> + .long_name = NULL_IF_CONFIG_SMALL("Cirrus Logic AccuPak"), > > > > nit: space before } > > > > Overall, this is looking good, thank you. > > All it's missing is a libavcodec minor version bump. > > > > Have you tested that it compiles with > > > > configure --disable-everything --enable-encoder=cljr > > It compiles. > But there is no check in file if cljr decoder is enabled. > So it compiles stuff which will never be used. > I plan to fix it in another commit.
OK, that's good. Do you have git set up locally already? If not, do it :) If you need assistance, check doc/git-howto.txt, send me private email or join IRC. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
