On Wed, Dec 07, 2011 at 04:35:37PM -0800, Alex Converse wrote: > On Wed, Dec 7, 2011 at 4:28 PM, Diego Biurrun <[email protected]> wrote: > > On Wed, Dec 07, 2011 at 04:16:10PM -0800, Alex Converse wrote: > >> On Wed, Dec 7, 2011 at 4:07 PM, Diego Biurrun <[email protected]> wrote: > >> > > >> > Author: Diego Biurrun <[email protected]> > >> > Committer: Diego Biurrun <[email protected]> > >> > Date: Wed Sep 21 18:46:56 2011 +0200 > >> > > >> > tests/tools/examples: Replace direct exit() calls by return. > >> > >> I don't see a review on the patch thread. > > > > Look harder, Luca OKed the set. > > > >> avconv.c notes "not all OS-es handle main() return value" on its first > >> call to exit. > > > > You'll have to elaborate on the difference between return and exit() in > > main(), I'm not following what difference it could make and where you > > see the relationship to that obscure comment... > > I don't know happen to know what the difference is, but if you also > see not difference then why not leave it as is rather than cause more > useless churn?
If I had seen no difference, then I would indeed have left it as-is. The difference is that return is - IMO - cleaner style and I eliminated some ugly #undefs. Looks like a net improvement to me. Now on to delete that mysterious and confusing comment... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
