On Thu, Dec 08, 2011 at 02:37:18PM +0000, Måns Rullgård wrote: > Kostya Shishkov <[email protected]> writes: > > > On Thu, Dec 08, 2011 at 03:23:13PM +0100, Diego Biurrun wrote: > >> On Thu, Dec 08, 2011 at 02:11:47PM +0000, Måns Rullgård wrote: > >> > Paul B Mahol <[email protected]> writes: > >> > > >> > > --- > >> > > libavcodec/cljr.c | 6 ++++++ > >> > > 1 files changed, 6 insertions(+), 0 deletions(-) > >> > > >> > Why is this not two files? > >> > >> Since there is common code, that would require splitting the file > >> in three parts. For such a small file it does feel a bit like > >> overkill... > > > > common_init() there is only four lines, one of which is empty. > > And there's no other common code there. > > Though I don't see a point of splitting such trivial codec anyway. > > 6 sets of ifdefs is a bit too much for that tiny file. Let me try to > clean it up.
I, for one, welcome any sane code clean-up. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
