Janne Grunau <[email protected]> writes:
> On 2011-12-10 15:43:54 +0000, Mans Rullgard wrote:
>> This splits the loop filter functions into smaller, more SIMD-friendly
>> functions.
>>
>> Signed-off-by: Mans Rullgard <[email protected]>
>> ---
>> libavcodec/rv34dsp.h | 21 +++-
>> libavcodec/rv40.c | 69 ++++++++----
>> libavcodec/rv40dsp.c | 296
>> ++++++++++++++++++++++++++++++--------------------
>> 3 files changed, 240 insertions(+), 146 deletions(-)
>>
[...]
>> + rv40_adaptive_loop_filter(&r->rdsp, C,
>> s->uvlinesize, j*8,
>> clip_cur,
>> clip_left,
>> - alpha, beta, betaC, 1, 1);
>> + alpha, beta, betaC, 1, 1, 1);
>
> all the rv40_adaptive_loop_filter calls could nicer and shorter
> indented. Just touching modified lines would be ok too but please
> be consistent.
I really don't understand what you're trying to say there. If you have
ideas for making that function less eye-bleed inducing, don't keep them
to yourself.
[...]
>> + for(i = 0; i < 4; i++, src += stride){
>
> missing spaces after for and )
It already looked like that. I have no intention of fixing every minor
cosmetic issue when moving around large chunks of code. If you want it
fixed, send a patch.
> otherwise ok
Do you insist on having the whitespace fine-tuned, or can we focus on
the important work (optimisations) first?
--
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
