On Fri, Dec 16, 2011 at 01:31:28PM -0500, Derek Buitenhuis wrote:
> It doesn't make much sense to clip pre-shift,
> nor is it correct for proper decoding.
> 
> Signed-off-by: Derek Buitenhuis <[email protected]>
> ---
>  libavcodec/wavpack.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
> index 11e9904..5358967 100644
> --- a/libavcodec/wavpack.c
> +++ b/libavcodec/wavpack.c
> @@ -405,12 +405,12 @@ static inline int 
> wv_get_value_integer(WavpackFrameContext *s, uint32_t *crc, in
>      }
>  
>      bit = (S & s->and) | s->or;
> -    bit = (((S + bit) << s->shift) - bit);
> +    bit = (((S + bit) << s->shift) - bit) << s->post_shift;
>  
>      if(s->hybrid)
>          bit = av_clip(bit, -s->hybrid_maxclip, s->hybrid_maxclip - 1);
>  
> -    return bit << s->post_shift;
> +    return bit;
>  }
>  
>  static float wv_get_value_float(WavpackFrameContext *s, uint32_t *crc, int S)
> -- 

LGTM
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to