On 12/17/2011 09:05 AM, Shitiz Garg wrote:

> channels would be 0 sometimes and would cause floating point exception
> Fixes bugzilla #124
> 
> ---
> libavcodec/adpcm.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
> index 3ada328..14713ae 100644
> --- a/libavcodec/adpcm.c
> +++ b/libavcodec/adpcm.c
> @@ -101,8 +101,9 @@ static av_cold int adpcm_decode_init(AVCodecContext * 
> avctx)
>         max_channels = 6;
>         break;
>     }
> -    if(avctx->channels > max_channels){
> -        return -1;
> +    if (avctx->channels <= 0 || avctx->channels > max_channels) {
> +        av_log(avctx, AV_LOG_ERROR, "Invalid number of channels\n");
> +        return AVERROR(EINVAL);
>     }
> 
>     switch(avctx->codec->id) {


looks good.

-Justin

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to