On 18/12/11 18:53, Uoti Urpala wrote:
On Sun, 2011-12-18 at 17:20 +0000, Mans Rullgard wrote:
- int age;
+ attribute_deprecated int age;
IMO setting attribute_deprecated immediately is a bad idea.
Why?
Unless you want your application to break when used with libavcodec
compiled yesterday you can't remove mentions of the field immediately.
Who exactly?
Thus warnings like this produce clutter that only hides real issues
unless you disable deprecation warnings completely or add redundant
version checks. In this case removing code setting the field now rather
than later doesn't even give any benefit whatsoever: setting it causes no
harm and there is no new API to test.
Let me try to make the whole thing more understandable:
- a custom get_buffer would have to set it in order to be compatible
with the past (it could set it depending on FF_API_AVFRAME_AGE or
equivalent version check, I think)
- not setting it would break the older code.
- setting it would trigger a warning in the new code.
You are suggesting not to have it attribute_deprecated for a bit since
it would just add another warning you can't do much for.
lu
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
