On 12/15/2011 02:06 PM, Shitiz Garg wrote:
> audio_subsegments would be 0 and cause floating point exceptions
> Fixes bugzilla #144
> ---
> libavformat/mtv.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/libavformat/mtv.c b/libavformat/mtv.c
> index c3fb15c..77f176b 100644
> --- a/libavformat/mtv.c
> +++ b/libavformat/mtv.c
> @@ -106,6 +106,12 @@ static int mtv_read_header(AVFormatContext *s,
> AVFormatParameters *ap)
>
> avio_skip(pb, 4);
> audio_subsegments = avio_rl16(pb);
> +
> + if (audio_subsegments == 0) {
> + av_log_ask_for_sample(s, "audio_subsegments == 0 not supported\n");
> + return AVERROR_INVALIDDATA;
> + }
> +
> mtv->full_segment_size =
> audio_subsegments * (MTV_AUDIO_PADDING_SIZE +
> MTV_ASUBCHUNK_DATA_SIZE) +
> mtv->img_segment_size;
looks fine to me in general.
but maybe change the message to "MTV files without audio are not supported"
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
