Hi,

On Mon, Dec 19, 2011 at 5:37 AM, Kostya Shishkov
<[email protected]>wrote:

> On 19 December 2011 14:32, Diego Biurrun <[email protected]> wrote:
> > On Mon, Dec 19, 2011 at 06:52:28PM +0530, Aneesh Dogra wrote:
> >> ---
> >>  libavcodec/xl.c |    6 ++++++
> >>  1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > I already told you to fix the log message, please do it.
> >
> >> --- a/libavcodec/xl.c
> >> +++ b/libavcodec/xl.c
> >> @@ -68,6 +68,12 @@ static int decode_frame(AVCodecContext *avctx,
> >>
> >>      stride = avctx->width - 4;
> >> +
> >> +    if (buf_size < avctx->width * avctx->height) {
> >> +        av_log(NULL, AV_LOG_ERROR, "buffer size is less that
> width*height\n");
> >
> > less thaN
> >
> > But even better would be
> >
> >  "Buffer size is smaller than picture size.\n"
>
> That message would be wrong since we're talking about compressed
> (or heavily quantised) data size and not picture itself.
>

This format isn't really compressed.

Patch itself is OK if the log msg and the commit msg are fixed.

Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to