Hi, On Thu, Dec 22, 2011 at 2:01 AM, Anton Khirnov <[email protected]> wrote: [..] > + memset(buf->base[0], 128, ret); /* XXX this shouldn't be needed, but > + some codecs rely on it now */
Which? We should fix it. This is slow and unnecessary and wrong for anything but 8bpc content. I remember H264 grayscale videos working in avconv and not in avplay in the past, these kind of hacks are why. I fixed that. We should fix this here also. > + if (s->flags & CODEC_FLAG_EMU_EDGE) > + buf->data[i] = buf->base[i]; // XXX h264 needs this Very confusing comment, and probably wrongly placed. > + buf->data[i] = buf->base[i] + > + FFALIGN((buf->linesize[i]*edge >> v_shift) + > + (pixel_size*edge>> h_shift), 32); Spaces around >>. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
