On Thu, Dec 22, 2011 at 11:58:15PM +0100, Janne Grunau wrote: > On 2011-12-22 21:50:25 +0100, Diego Biurrun wrote: > > The demuxer depends on the mov code, which in turn depends on the > > mov chan tag code, so link against it. > > Have you loked if functions used from cafdec.c actually depend on > something in mov_chan.c?
cafdec.c uses ff_mov_read_esds and ff_mov_get_lpcm_codec_id from mov.c. mov.c uses ff_mov_get_channel_layout, which is defined in mov_chan.c. > please write channel out and I wouldn't mind a more comprehensible > commit description IIUC the name of the tag is just chan, from mov_chan.c: /** * mov 'chan' tag reading/writing. * @author Justin Ruggles */ So how about The demuxer depends on code from mov.c, which in turn depends on code from mov_chan.c, so link against it. ? > > --- a/libavformat/Makefile > > +++ b/libavformat/Makefile > > @@ -49,7 +49,8 @@ OBJS-$(CONFIG_BFI_DEMUXER) += bfi.o > > OBJS-$(CONFIG_BMV_DEMUXER) += bmv.o > > OBJS-$(CONFIG_C93_DEMUXER) += c93.o vocdec.o voc.o > > -OBJS-$(CONFIG_CAF_DEMUXER) += cafdec.o caf.o mov.o riff.o > > isom.o > > +OBJS-$(CONFIG_CAF_DEMUXER) += cafdec.o caf.o mov.o riff.o \ > > + isom.o mov_chan.o > > I would add mov_chan.o directly after mov.o, feel free to sort the > objects alphabetically Why not - changed locally. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
