On 23.12.2011 13:55, Alexander Strange wrote:
On Thu, Dec 22, 2011 at 10:49 PM, Ronald S. Bultje<[email protected]> wrote:
Hi,
On Thu, Dec 22, 2011 at 7:37 PM, Sergey Radionov<[email protected]> wrote:
added forgotten ResetEvent to pthread_cond_broadcast.
added "volatile" to broadcast flag (since it using from multiple threads).
---
libavcodec/w32pthreads.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
LGTM, pushed.
I think this volatile is useless. It would only have an effect if
is_broadcast was written to/read from twice without another side
effect (an external function call) in between, and I don't see that
here. Is there any code difference?
I am always think that any memory that accessed from different threads must be declared as
"volatile" (to not allow compiler put it's value to cpu register and use it from there). Am I wrong?
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
--
With best wishes,
Sergey Radionov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
