On Di, Dez 27, 2011 at 00:22:49 (CET), Janne Grunau wrote:

> On 2011-12-27 00:02:23 +0100, Reinhard Tartler wrote:
>> This fixes a build failure on kFreeBSD, which has recently started to
>> provide v4l2 headers.
>
> it provides linux/videodev2.h ? strange

Yeah, FreeBSD seems to support video4linux2 these days, and adjusting
each and every application just for the path is not necessary. Just FYI:

(sid)siretart@asdfasdf:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/kFreeBSD unstable (sid)
Release:        unstable
Codename:       sid
(sid)siretart@asdfasdf:~$ uname -a
GNU/kFreeBSD asdfasdf 8.2-1-amd64 #0 Sat Feb 19 23:10:25 CET 2011 x86_64 amd64 
AMD Sempron(tm) Processor 3000+ GNU/kFreeBSD
(sid)siretart@asdfasdf:~$ find /usr/include/linux/
/usr/include/linux/
/usr/include/linux/videodev.h
/usr/include/linux/videodev2.h
(sid)siretart@asdfasdf:~$


>> However, libavdevice/v4l2.c additionally includes
>> the header files <asm/types.h>, which is too Linux specific here.
>> Therefore, this patch restricts libavdevice's support to Linux hosts
>> until libavdevice gets fixed.
>
> At least here asm/types.h is not needed and following patch is enough.
> If necessary we should tests if asm/types.h is required and include
> it only then.
>

[...]

>
> ---8<---
> ---
>  libavdevice/v4l2.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
> index 0c61f46..eb16171 100644
> --- a/libavdevice/v4l2.c
> +++ b/libavdevice/v4l2.c
> @@ -39,7 +39,6 @@
>  #if HAVE_SYS_VIDEOIO_H
>  #include <sys/videoio.h>
>  #else
> -#include <asm/types.h>
>  #include <linux/videodev2.h>
>  #endif
>  #include <time.h>

this patch allows libavdevice/v4l2.o to compile and
libavdevice/libavdevice.a to link again.

Thanks & Cheers,
 Reinhard

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to