On 27/12/2011 8:20 AM, Luca Barbato wrote:
Check capabilities directly in the function, further simplify the code.
---
  libavdevice/v4l2.c |   70 +++++++++++++++++++++++++--------------------------
  1 files changed, 34 insertions(+), 36 deletions(-)

[...]

      if (fd<  0) {
+        err = errno;
+
          av_log(ctx, AV_LOG_ERROR, "Cannot open video device %s : %s\n",
-               ctx->filename, strerror(errno));
+               ctx->filename, strerror(err));

-        return AVERROR(errno);
+        return AVERROR(err);
      }

I am not sure I understand the point of this bit? Why bother setting
err when we're returning anyway?

The rest looks OK, but I'm wondering why the capabilities verbose
output was ditched?

- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to