On Tue, Dec 27, 2011 at 07:29:55PM +0100, Aneesh Dogra wrote: > Module: libav > Branch: master > Commit: bd96be6e2739dbe5b7a467a318ebfb6241c15eba > > Author: Aneesh Dogra <[email protected]> > Committer: Ronald S. Bultje <[email protected]> > Date: Tue Dec 27 11:56:07 2011 +0530 > > mpegvideo_enc: K&R cosmetics > > Signed-off-by: Ronald S. Bultje <[email protected]> > > --- a/libavcodec/mpegvideo_enc.c > +++ b/libavcodec/mpegvideo_enc.c > @@ -76,140 +78,169 @@ void ff_convert_matrix(DSPContext *dsp, int > (*qmat)[64], uint16_t (*qmat16)[2][6 > ) { > - for(i=0;i<64;i++) { > - const int j= dsp->idct_permutation[i]; > - /* 16 <= qscale * quant_matrix[i] <= 7905 */ > - /* 19952 <= ff_aanscales[i] * qscale * > quant_matrix[i] <= 249205026 */ > - /* (1 << 36) / 19952 >= (1 << 36) / (ff_aanscales[i] * > qscale * quant_matrix[i]) >= (1 << 36) / 249205026 */ > - /* 3444240 >= (1 << 36) / (ff_aanscales[i] * > qscale * quant_matrix[i]) >= 275 */ > + for (i = 0; i < 64; i++) { > + const int j = dsp->idct_permutation[i]; > + /* 16 <= qscale * quant_matrix[i] <= 7905 > + * Assume x = ff_aanscales[i] * qscale * quant_matrix[i] > + * 19952 <= x <= 249205026 > + * (1 << 36) / 19952 >= (1 << 36) / (x) >= (1 << 36) / > 249205026 > + * 3444240 >= (1 << 36) / (x) >= 275 */
Ronald, WTF? How does this even remotely match the log message description? (Even leaving aside the small detail that I explicitly rejected this.) Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
