On Mon, Jan 02, 2012 at 02:19:00PM +0530, Gaurav Narula wrote:
>
> --- a/avprobe.c
> +++ b/avprobe.c
> @@ -138,13 +140,24 @@ static void show_packet(AVFormatContext *fmt_ctx,
> AVPacket *pkt)
> printf("[PACKET]\n");
> printf("codec_type=%s\n" , media_type_string(st->codec->codec_type));
> printf("stream_index=%d\n" , pkt->stream_index);
> - printf("pts=%s\n" , ts_value_string (val_str, sizeof(val_str),
> pkt->pts));
> - printf("pts_time=%s\n" , time_value_string(val_str, sizeof(val_str),
> pkt->pts, &st->time_base));
> - printf("dts=%s\n" , ts_value_string (val_str, sizeof(val_str),
> pkt->dts));
> - printf("dts_time=%s\n" , time_value_string(val_str, sizeof(val_str),
> pkt->dts, &st->time_base));
> - printf("duration=%s\n" , ts_value_string (val_str, sizeof(val_str),
> pkt->duration));
> - printf("duration_time=%s\n", time_value_string(val_str, sizeof(val_str),
> pkt->duration, &st->time_base));
> - printf("size=%s\n" , value_string (val_str, sizeof(val_str),
> pkt->size, unit_byte_str));
> + printf("pts=%s\n" , ts_value_string (val_str, sizeof(val_str),
> + pkt->pts));
> + printf("pts_time=%s\n" , time_value_string(val_str, sizeof(val_str),
> + pkt->pts,
> + &st->time_base));
> + printf("dts=%s\n" , ts_value_string (val_str, sizeof(val_str),
> + pkt->dts));
> + printf("dts_time=%s\n" , time_value_string(val_str, sizeof(val_str),
> + pkt->dts,
> + &st->time_base));
> + printf("duration=%s\n" , ts_value_string (val_str, sizeof(val_str),
> + pkt->duration));
> + printf("duration_time=%s\n", time_value_string(val_str, sizeof(val_str),
> + pkt->duration,
> + &st->time_base));
> + printf("size=%s\n" , value_string (val_str, sizeof(val_str),
> + pkt->size,
> + unit_byte_str));
These are function invocations. If you are going to change this at all,
drop the spaces before ',' and '('.
> --- a/tests/rotozoom.c
> +++ b/tests/rotozoom.c
>
> cb++;
> cr++;
> - p += -wrap3 + 2 * 3;
> + p += -wrap3 + 2 * 3;
> lum += -wrap + 2;
This was correct before.
> --- a/tests/tiny_psnr.c
> +++ b/tests/tiny_psnr.c
> @@ -135,42 +138,43 @@ int main(int argc,char* argv[]){
> else
> - psnr= 1000*F-1; //floating point free infinity :)
> + psnr = 1000 * F - 1; //floating point free infinity :)
space after //
Check this everywhere else please.
> printf("stddev:%5d.%02d PSNR:%3d.%02d MAXDIFF:%5d bytes:%9d/%9d\n",
> - (int)(dev/F), (int)(dev%F),
> - (int)(psnr/F), (int)(psnr%F),
> + (int)(dev / F), (int)(dev % F),
> + (int)(psnr / F), (int)(psnr % F),
> maxdist,
> size0, size1);
Indentation is off.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel