On Tue, Jan 3, 2012 at 2:20 PM, Ronald S. Bultje <[email protected]> wrote: > Hi, > > On Tue, Jan 3, 2012 at 11:33 AM, Kostya Shishkov > <[email protected]> wrote: >> On Tue, Jan 03, 2012 at 11:22:11AM -0800, Ronald S. Bultje wrote: >>> --- >>> libswscale/swscale.c | 10 +++++----- >>> 1 files changed, 5 insertions(+), 5 deletions(-) >> >> the change looks OK but it makes function look even WTFier than before >> (especially the name) > > How so? The callers have pointers to RGB LUTs (offsets derived from > U/V values already applied), and give that plus Y value (index in > table) to the function, and the function then knows what to do. > > Alternatives are welcome.
Perhaps add a comment explaining this? If something is not immediately obvious from the code, it should have a comment. Jason _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
