Hi, On Sat, Jan 7, 2012 at 11:58 AM, Diego Biurrun <[email protected]> wrote: > The intention is to separate externally used parts of cabac.h from the > rest of the file and especially the CABAC inline functions in cabac.h. > > This fixes standalone compilation of some decoders with > --disable-optimizations. > cabac.h defines some inline functions that use symbols from cabac.c. Without > optimizations these inline functions are not eliminated and linking fails with > references to non-existing symbols. > --- > libavcodec/cabac.h | 11 +---------- > libavcodec/h264.h | 11 ++++++++++- > libavcodec/x86/h264_i386.h | 2 +- > 3 files changed, 12 insertions(+), 12 deletions(-)
I'd prefer if this went into a separate header. I'm fine with that being called h264_cabac.h or so, but the problem I see with adding it to h264 is that we lose the distinction between the bit reading layer (that being cabac:this or vlc:get_bits.h) and the actual decoder, which is what interprets the bits, in the h264 decoder layer, which h264.h is part of. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
