On 09/01/12 10:53, Diego Biurrun wrote:
On Mon, Jan 09, 2012 at 09:37:06AM +0100, Luca Barbato wrote:
Remove some unneeded memsets.
---
  libavdevice/v4l2.c |   58 ++++++++++++++++++++++-----------------------------
  1 files changed, 25 insertions(+), 33 deletions(-)

Previously the structures had all their fields initialized to 0,
now you just initialize a few select fields.  If you are confident
this will not create sideeffects, then patch is OK, some nits below.

c99 designated initializer would set to 0 fields not otherwise set.

framerate_q was not previously memset to zero - is that on purpose?

Yes. I still want to change a bit that part but while I was there I uniformed it.

lu

--

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to