On 9 January 2012 12:31, Laurentiu Cristian Ion <[email protected]> wrote: > Hi, > > 2012/1/9 Kostya Shishkov <[email protected]> >> >> On 9 January 2012 12:14, Laurentiu Ion <[email protected]> >> wrote: >> > --- >> > libavcodec/kmvc.c | 123 >> > ++++++++++++++++++++++++++--------------------------- >> > 1 files changed, 61 insertions(+), 62 deletions(-) >> > >> > diff --git a/libavcodec/kmvc.c b/libavcodec/kmvc.c >> > index 6c55863..3c74550 100644 >> > --- a/libavcodec/kmvc.c >> > +++ b/libavcodec/kmvc.c >> > @@ -48,6 +48,8 @@ typedef struct KmvcContext { >> > uint8_t *frm0, *frm1; >> > } KmvcContext; >> > >> > +GetByteContext g; >> >> Global variable like this is unacceptable. > > > I thought that instead of passing it as an argument in every function maybe > it's better... if it was C++ I would have made it private... > How do you want me to declare it?
Your previous patch was almost fine. IIRC Ronald wanted you to pass GetByteContext into macro explicitly as an argument, nothing else. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
