On 2012-01-10 09:14:01 -0800, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 10, 2012 at 9:09 AM, Janne Grunau <[email protected]> wrote: > > Under certain conditions pictures could be released before they were > > returned with frame-threading. Broken mv computation in the upcoming > > rv34 frame-threading patch was caused by this. > > > > To prevent contexts from running out of available pictures the loop > > releasing "unused" pictures has to be run for B frames too. > > --- > > libavcodec/mpegvideo.c | 41 +++++++++++++++++++++++++---------------- > > 1 files changed, 25 insertions(+), 16 deletions(-) > > Assuming you've done some reasonable testing (for thr in 2 3 4 5 6 7 > 8; do make THREADS=${thr} fate; done or so) and this doesn't break > anything that wasn't already broken, LGTM.
did that for both slice and frame THREAD_TYPE > (I'm not saying that because I don't trust you; altering this code > does a lot of evil stuff deep within that I don't really fully > understand. I'm pretty sure your patch is fine but feel more > comfortable if we've done some harsh testing.) I'm also a little surprised that it apparently doesn't break things. Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
