On 01/10/2012 04:21 PM, Aneesh Dogra wrote:
> + case CODEC_ID_ADPCM_XA: {
> + unsigned char buffer[128];
> +
> + while (bytestream2_get_bytes_left(&c->g) >= 128) {
> + bytestream2_get_buffer(&c->g, buffer, 128);
> + xa_decode(samples, buffer, &c->status[0], &c->status[1],
> + avctx->channels);
> samples += 28 * 8;
> buf_size -= 128;
> }
> break;
> + }
you forgot to remove the "buf_size -= 128". the rest of the patch looks
ok. a few small cosmetic issues, but nothing worth keeping it from being
committed. make sure to also test 4xm, adx, and smjpeg manually though
since i'm pretty sure they still aren't covered by fate.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
