On 01/11/2012 10:58 AM, Diego Biurrun wrote: > On Wed, Jan 11, 2012 at 10:41:47AM -0500, Justin Ruggles wrote: >> On 01/11/2012 10:26 AM, Diego Biurrun wrote: >> >>> On Wed, Jan 11, 2012 at 08:44:39AM -0500, Justin Ruggles wrote: >>>>> --- a/tests/fate/dpcm.mak >>>>> +++ b/tests/fate/dpcm.mak >>>>> @@ -1,42 +1,44 @@ >>>>> -FATE_TESTS += fate-adpcm-ea-r2 >>>>> +FATE_DPCM += fate-adpcm-ea-r2 >>>>> fate-adpcm-ea-r2: CMD = crc -i $(SAMPLES)/ea-mpc/THX_logo.mpc -vn >>>>> >>>>> -FATE_TESTS += fate-adpcm-ea-r3 >>>>> +FATE_DPCM += fate-adpcm-ea-r3 >>>>> fate-adpcm-ea-r3: CMD = crc -i $(SAMPLES)/ea-vp6/THX_logo.vp6 -vn >>>>> >>>>> -FATE_TESTS += fate-creative-adpcm >>>>> +FATE_DPCM += fate-creative-adpcm >>>>> fate-creative-adpcm: CMD = md5 -i $(SAMPLES)/creative/intro-partial.wav >>>>> -f s16le >>>>> >>>>> -FATE_TESTS += fate-creative-adpcm-8-2bit >>>>> +FATE_DPCM += fate-creative-adpcm-8-2bit >>>>> fate-creative-adpcm-8-2bit: CMD = md5 -i >>>>> $(SAMPLES)/creative/BBC_2BIT.VOC -f s16le >>>>> >>>>> -FATE_TESTS += fate-creative-adpcm-8-2.6bit >>>>> +FATE_DPCM += fate-creative-adpcm-8-2.6bit >>>>> fate-creative-adpcm-8-2.6bit: CMD = md5 -i >>>>> $(SAMPLES)/creative/BBC_3BIT.VOC -f s16le >>>>> >>>>> -FATE_TESTS += fate-creative-adpcm-8-4bit >>>>> +FATE_DPCM += fate-creative-adpcm-8-4bit >>>>> fate-creative-adpcm-8-4bit: CMD = md5 -i >>>>> $(SAMPLES)/creative/BBC_4BIT.VOC -f s16le >>>>> >>>>> -FATE_TESTS += fate-ea-mad-adpcm-ea-r1 >>>>> +FATE_DPCM += fate-ea-mad-adpcm-ea-r1 >>>>> fate-ea-mad-adpcm-ea-r1: CMD = framecrc -i >>>>> $(SAMPLES)/ea-mad/NFS6LogoE.mad >>>>> >>>>> -FATE_TESTS += fate-ea-tqi-adpcm >>>>> +FATE_DPCM += fate-ea-tqi-adpcm >>>>> fate-ea-tqi-adpcm: CMD = framecrc -i >>>>> $(SAMPLES)/ea-wve/networkBackbone-partial.wve -frames:v 26 >>>>> >>>>> -FATE_TESTS += fate-idroq-video-dpcm >>>>> +FATE_DPCM += fate-idroq-video-dpcm >>>>> fate-idroq-video-dpcm: CMD = framecrc -i $(SAMPLES)/idroq/idlogo.roq >>>>> >>>>> -FATE_TESTS += fate-psx-str-v3-adpcm_xa >>>>> +FATE_DPCM += fate-psx-str-v3-adpcm_xa >>>>> fate-psx-str-v3-adpcm_xa: CMD = framecrc -i >>>>> $(SAMPLES)/psx-str/abc000_cut.str -vn >>>>> >>>>> -FATE_TESTS += fate-qt-msadpcm-stereo >>>>> +FATE_DPCM += fate-qt-msadpcm-stereo >>>>> fate-qt-msadpcm-stereo: CMD = md5 -i >>>>> $(SAMPLES)/qt-surge-suite/surge-2-16-L-ms02.mov -f s16le >>>>> >>>>> -FATE_TESTS += fate-qt-msimaadpcm-stereo >>>>> +FATE_DPCM += fate-qt-msimaadpcm-stereo >>>>> fate-qt-msimaadpcm-stereo: CMD = md5 -i >>>>> $(SAMPLES)/qt-surge-suite/surge-2-16-L-ms11.mov -f s16le >>>>> >>>>> -FATE_TESTS += fate-thp-mjpeg-adpcm >>>>> +FATE_DPCM += fate-thp-mjpeg-adpcm >>>>> fate-thp-mjpeg-adpcm: CMD = framecrc -idct simple -i >>>>> $(SAMPLES)/thp/pikmin2-opening1-partial.thp >>>>> >>>>> -FATE_TESTS += fate-dpcm-xan >>>>> +FATE_DPCM += fate-dpcm-xan >>>>> fate-dpcm-xan: CMD = md5 -i $(SAMPLES)/wc4-xan/wc4_2.avi -vn -f s16le >>>>> >>>>> +FATE_TESTS += $(FATE_DPCM) >>>>> +fate-dpcm: $(FATE_DPCM) >>>> >>>> Please separate dpcm from adpcm. They are in separate files, and one is >>>> not likely to be working on both at the same time. It doesn't make much >>>> sense to run them all together. >>> >>> Does it make sense to split the adpcm tests off into their own file? >> >> probably so. > > OK, > >>> Mind you, there are only two dpcm tests... >> >> sierra-audio, and the 2 interplay-mve tests should also be in the dpcm >> test group (though probably also split into separate audio/video tests). >> >> I think we also may need a way to organize groups separately from adding >> them to FATE_TESTS, and across multiple mak files. Either that or start >> splitting up more tests between audio and video. > > Let's split the tests. Point out stuff to me, I will do the splitting.
Not sure if this list is complete, but it's most of them at least. Some can be split, some might just need to be converted to demuxer tests or even removed. ea-tqi-adpcm - video: eatqi - audio: adpcm_ea ea-dct - video: mdec - audio: adpcm_ea ea-mad-adpcm-ea-r1 - video: eamad - audio: adpcm_ea_r1 amv - video: amv - audio: adpcm_ima_amv fate-truemotion1-15 fate-truemotion1-24 - video: trumotion1 - audio: adpcm_ima_dk3 ea-tgv-ima-ea-eacs - video: eatgv - audio: adpcm_ima_ea_eacs ea-tgv-ima-ea-sead - video: eatgv - audio: adpcm_ima_ea_sead smjpeg - video: copy (??? need separate demux test maybe) - audio: adpcm_ima_smjpeg feeble-dxa - video: dxa - audio: adpcm_ms thp-mjpeg-adpcm - video: thp - audio: adpcm_thp psx-str - video: mdec - audio: adpcm_xa (we already have psx-str-v3-adpcm_xa. convert to a demuxer test? unless it adds more code coverage) delphine-cin - video: dsicinvideo - audio: dsicinaudio interplay-mve-16bit interplay-mve-8bit - video: interplayvideo - audio: interplay_dpcm qtrle-1bit qtrle-2bit - video: qtrle - audio: mace6 (we already have separate mac6 tests) tscc-15bit - video: camtasia - audio: pcm_mulaw (we already have several mulaw tests) ea-mad-pcm-planar - video: eamad - audio: pcm_s16le_planar film-cvid-pcm-stereo-8bit - video: cinepak - audio: pcm_s8 idroq-video-dpcm - video: roqvideo - audio: roq_dpcm smacker - video: smackvid - audio: smackaud sierra-vmd - video: vmdvideo - audio: vmdaudio tests using pcm_s16be that don't need to: tiertex-seq, caf, qt-rawpcm-16bit-stereo-signed-be tests using pcm_s16le that don't need to: id-cin-video, nuv, wc3movie-xan, w64 tests using pcm_u8 that don't need to: corepng, sp5x, iff-pcm, siff, armovie-escape124, 8bps, tmv, bethsoft-vid, bfi, creatureshock-avs, cyberia-c93, qt-rawpcm-8bit-mono-unsigned, qt-rawpcm-8bit-stereo-unsigned _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
