On Wed, Jan 18, 2012 at 05:01:49PM +0200, Laurentiu Cristian Ion wrote:
>
> --- a/libavcodec/dxa.c
> +++ b/libavcodec/dxa.c
> @@ -39,40 +40,56 @@ typedef struct DxaDecContext {
>
> -static int decode_13(AVCodecContext *avctx, DxaDecContext *c, uint8_t*
> dst, uint8_t *src, uint8_t *ref)
> -{
> - uint8_t *code, *data, *mv, *msk, *tmp, *tmp2;
> +static int decode_13(DxaDecContext *c, uint8_t *dst, uint8_t *ref)
> + {
stray one-space indentation
> - for(j = 0; j < avctx->height; j += 4){
> - for(i = 0; i < avctx->width; i += 4){
> + for (j = 0; j < c->avctx->height; j += 4) {
> + for (i = 0; i < c->avctx->width; i += 4) {
unrelated cosmetics
> case 0: // skip
> case 5: // skip in method 12
> - for(y = 0; y < 4; y++){
> + for (y = 0; y < 4; y++) {
more
> @@ -305,13 +319,13 @@ static av_cold int decode_init(AVCodecContext *avctx)
> }
>
> static av_cold int decode_end(AVCodecContext *avctx)
> -{
> + {
unrelated and wrong
> av_freep(&c->decomp_buf);
> - if(c->prev.data[0])
> + if (c->prev.data[0])
> avctx->release_buffer(avctx, &c->prev);
> - if(c->pic.data[0])
> + if (c->pic.data[0])
> avctx->release_buffer(avctx, &c->pic);
unrelated
> @@ -321,11 +335,11 @@ AVCodec ff_dxa_decoder = {
> .name = "dxa",
> .type = AVMEDIA_TYPE_VIDEO,
> .id = CODEC_ID_DXA,
> - .priv_data_size = sizeof(DxaDecContext),
> + .priv_data_size = sizeof (DxaDecContext),
> .init = decode_init,
> .close = decode_end,
> .decode = decode_frame,
> .capabilities = CODEC_CAP_DR1,
> - .long_name = NULL_IF_CONFIG_SMALL("Feeble Files/ScummVM DXA"),
> + .long_name = NULL_IF_CONFIG_SMALL("Feeble Files/ScummVM DXA"),
Both are unrelated and wrong.
There are more in the patch. Please remove all unrelated changes from
your patch and resend. Patches must never contain unrelated changes.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
