On Wed, Jan 18, 2012 at 12:39 AM, Nathan Caldwell <[email protected]> wrote: > > --- > libavcodec/aacpsy.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/aacpsy.c b/libavcodec/aacpsy.c > index 04feea3..577d8fb 100644 > --- a/libavcodec/aacpsy.c > +++ b/libavcodec/aacpsy.c > @@ -823,8 +823,7 @@ static FFPsyWindowInfo psy_lame_window(FFPsyContext *ctx, > float const *const pfe = pf + AAC_BLOCK_SIZE_LONG / > (AAC_NUM_BLOCKS_SHORT * PSY_LAME_NUM_SUBBLOCKS); > float p = 1.0f; > for (; pf < pfe; pf++) > - if (p < fabsf(*pf)) > - p = fabsf(*pf); > + p = FFMAX(p, fabsf(*pf));
Do we double evaluate fabsf(*pf) here? Maybe using an explicit temp would be better? This isn't where we spend most of our cycles IIRC so I guess this is OK as-is. > pch->prev_energy_subshort[i] = energy_subshort[i + > PSY_LAME_NUM_SUBBLOCKS] = p; > energy_short[1 + i / PSY_LAME_NUM_SUBBLOCKS] += p; > /* NOTE: The indexes below are [i + 3 - 2] in the LAME source. > -- > 1.7.5.4 _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
