On 01/20/2012 07:12 AM, Måns Rullgård wrote: > Anton Khirnov <[email protected]> writes: > >> On Thu, 19 Jan 2012 15:01:23 -0500, Justin Ruggles >> <[email protected]> wrote: >>> Bethsoft video is VFR, but in this case using the average frame rate >>> generates nearly correct timestamps. Unfortunately there is nothing >>> in the bitstream to indicate average FPS, so we must set it manually. >>> --- >>> tests/fate/video.mak | 2 +- >>> tests/ref/fate/bethsoft-vid | 140 >>> +++++++++++++++++++++--------------------- >>> 2 files changed, 71 insertions(+), 71 deletions(-) >>> >> >> Do i understand correctly that this is a hack around rawenc not passing >> the timestamps? > > Sure looks like some kind of hack to me. Hacking the tests to make them > appear correct is definitely wrong.
Yeah, it is a hack I suppose. avconv just doesn't handle vfr well. Yes, rawenc should pass timestamps, but it doesn't, and if we change that many tests will break. avconv assumes a fixed frame rate and uses the source stream time base, which is completely wrong and leads to incorrect timestamps. So anyway, I'll drop this patch. It's not that important. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
