On 1/15/12, Kostya Shishkov <[email protected]> wrote: > On Sun, Jan 15, 2012 at 02:25:30PM +0100, Diego Biurrun wrote: >> On Sun, Jan 15, 2012 at 12:18:31PM +0100, Kostya Shishkov wrote: >> > >From 692a89179aee26511df683acf46cc919a329d8f1 Mon Sep 17 00:00:00 2001 >> > From: Eli Friedman <[email protected]> >> > Date: Fri, 16 Dec 2011 21:30:27 +0100 >> > Subject: [PATCH] Escape 130 (RPL) decoder >> > >> > Some fixes provided by Paul B Mahol <[email protected]> >> > and Michael Niedermayer <[email protected]> and me. >> > >> > Signed-off-by: Diego Biurrun <[email protected]> >> >> You should add your s-o-b here. > > added > >> The patch looks fine in principle. If you consider fixing the artifacts >> too much work, so be it, we will have to live with it. >> >> Also have a look at Justin's comments for Reinhard's version of this >> patch. > > Looked and took into account. > >> > --- /dev/null >> > +++ b/libavcodec/escape130.c >> > @@ -0,0 +1,307 @@ >> > +/* >> > + * Escape 130 Video Decoder >> >> video decoder >> >> > +static av_cold int escape130_decode_init(AVCodecContext *avctx) >> > +{ >> > + Escape130Context *s = avctx->priv_data; >> > + avctx->pix_fmt = PIX_FMT_YUV420P; >> > + >> > + if ((avctx->width & 1) || (avctx->height & 1)) { >> > + av_log(avctx, AV_LOG_ERROR, >> > + "Dimensions should be multiple of two.\n"); >> >> be a multiple >> >> > + return AVERROR(EINVAL); >> >> AVERROR_INVALIDDATA? >> >> IIUC EINVAL is for user-supplied parameters. >> >> > + // Note that this call will make us skip the rest of the blocks >> > + // if the frame prematurely ends >> >> nit: . > > Those too. >
Fine for me. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
