On Sun, Jan 29, 2012 at 09:31:07PM +0000, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol <[email protected]> > --- > libswscale/yuv2rgb.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-)
The patch content is probably OK, but the log message leaves something to be desired. First off - plural or singular format(s)? Noun and verb form do not agree. Then your log message is a description of a state, not a change. But commits are changes, so some verb is needed in your log message. Something along the lines of "make more generic" or so should do. The same applies to your other patch, which might possibly be squashed into this one. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
