On Mon, Jan 30, 2012 at 01:16:38PM +0000, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > On Mon, Jan 30, 2012 at 11:53:05AM +0000, Måns Rullgård wrote: > >> Diego Biurrun <[email protected]> writes: > >> > On Sun, Jan 29, 2012 at 11:56:04PM +0100, Diego Biurrun wrote: > >> >> On Sun, Jan 29, 2012 at 09:18:09PM +0000, Måns Rullgård wrote: > >> >> > Diego Biurrun <[email protected]> writes: > >> >> > > > >> >> > > --- a/tests/Makefile > >> >> > > +++ b/tests/Makefile > >> >> > > @@ -5,20 +5,18 @@ REFS = $(AREF) $(VREF) > >> >> > > $(VREF): avconv$(EXESUF) tests/vsynth1/00.pgm tests/vsynth2/00.pgm > >> >> > > $(AREF): avconv$(EXESUF) tests/data/asynth1.sw > >> >> > > > >> >> > > -tests/vsynth1/00.pgm: tests/videogen$(HOSTEXESUF) > >> >> > > - @mkdir -p tests/vsynth1 > >> >> > > +OBJDIRS += tests/data tests/vsynth1 tests/vsynth2 > >> >> > > + > >> >> > > +tests/vsynth1/00.pgm: tests/videogen$(HOSTEXESUF) | tests/vsynth1 > >> >> > > $(M)./$< 'tests/vsynth1/' > >> >> > > > >> >> > > -tests/vsynth2/00.pgm: tests/rotozoom$(HOSTEXESUF) > >> >> > > - @mkdir -p tests/vsynth2 > >> >> > > +tests/vsynth2/00.pgm: tests/rotozoom$(HOSTEXESUF) | tests/vsynth2 > >> >> > > $(M)./$< 'tests/vsynth2/' $(SRC_PATH)/tests/lena.pnm > >> >> > > > >> >> > > -tests/data/asynth1.sw: tests/audiogen$(HOSTEXESUF) > >> >> > > - @mkdir -p tests/data > >> >> > > +tests/data/asynth1.sw: tests/audiogen$(HOSTEXESUF) | tests/data > >> >> > > $(M)./$< $@ > >> >> > > > >> >> > > -tests/data/asynth-16000-1.sw: tests/audiogen$(HOSTEXESUF) > >> >> > > - @mkdir -p tests/data > >> >> > > +tests/data/asynth-16000-1.sw: tests/audiogen$(HOSTEXESUF) | > >> >> > > tests/data > >> >> > > $(M)./$< $@ 16000 1 > >> >> > > > >> >> > > tests/data/asynth%.sw tests/vsynth%/00.pgm: TAG = GEN > >> >> > > >> >> > OBJDIRS is a bit of a misnomer here, but I guess that's acceptable. > >> >> > >> >> Yeah, I noticed, but we already abuse that variable name in > >> >> doc/Makefile. > >> >> If you have a better suggestion, I'm all ears. The best I can currently > >> >> come up with is COMPONENTDIRS. > >> > > >> > BUILDDIRS > >> > GENERATEDDIRS > >> > >> Too long. > > > > Two characters longer is too long? > > GENERATED is two characters?
Let me say it with more precision: BUILDDIRS is two characters longer than OBJDIRS. > > Whatever, I'm pushing with OBJDIRS. > > I already said the patch was OK. And I understood you that way. I just tried to think of better replacement names for the suboptimal OBJDIRS. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
