"Ronald S. Bultje" <[email protected]> writes: > Hi, > > On Mon, Jan 30, 2012 at 9:52 PM, Anton Khirnov <[email protected]> wrote: >> On Mon, 30 Jan 2012 16:57:39 -0800, "Ronald S. Bultje" <[email protected]> >> wrote: >>> On Sun, Jan 29, 2012 at 8:48 AM, Anton Khirnov <[email protected]> wrote: >>> > Put all private fields at the end and mark them as such so they can be >>> > easily changed/removed. >>> > >>> > This breaks ABI. >>> > --- >>> > libavformat/avformat.h | 110 >>> > ++++++++++++++++++++++++++--------------------- >>> > 1 files changed, 61 insertions(+), 49 deletions(-) >>> >>> Looks OK. Somewhat unrelated: >>> >>> > + /** >>> > + * General purpose read-only value that the format can use. >>> > + */ >>> > + int value; >>> >>> WTF is that? >>> >> >> Raw demuxers store their codec id there.
Why? > I _bet_ you that can be cleaned up somehow, in an ABI-incompatible way > unfortunately. Then there is no time to waste. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
