On Wed, Feb 01, 2012 at 07:38:56AM -0800, Ronald S. Bultje wrote: > > --- /dev/null > +++ b/libswscale/output.c > @@ -0,0 +1,1521 @@ > + > +#include <inttypes.h>
stdint.h is enough. > +#include <string.h> > +#include <math.h> > +#include <stdio.h> > +#include "config.h" > +#include <assert.h> > +#include "swscale.h" > +#include "swscale_internal.h" > +#include "rgb2rgb.h" > +#include "libavutil/intreadwrite.h" > +#include "libavutil/cpu.h" > +#include "libavutil/avutil.h" > +#include "libavutil/mathematics.h" > +#include "libavutil/bswap.h" > +#include "libavutil/pixdesc.h" Separate local from system headers by an empty line, move libavutil headers before swscale ones. > +void ff_sws_init_output_funcs(SwsContext *c, > + yuv2planar1_fn *yuv2plane1, yuv2planarX_fn > *yuv2planeX, > + yuv2interleavedX_fn *yuv2nv12cX, > + yuv2packed1_fn *yuv2packed1, yuv2packed2_fn > *yuv2packed2, > + yuv2packedX_fn *yuv2packedX) This function is new, so please keep the lines short and indentation sane. Apart from that the patch looks sensible, assuming you just moved the code, which I did not verify in detail. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
